feat: cache OPL when loading from HTTP(S) #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnr
force-pushed
the
fetcher-caching
branch
from
2c906fe
to
82088f2
Compare
aeneasr
requested changes
Sep 18, 2023
| _, err = cw.GetNamespaceByName(ctx, "Document") | ||
| require.NoError(t, err) | ||
|
|
||
| time.Sleep(1 * time.Second) // warm cache |
There was a problem hiding this comment.
Please use cache.Wait() instead, otherwise this will be flaky
alnr
force-pushed
the
fetcher-caching
branch
from
82088f2
to
0c298ce
Compare
aeneasr
reviewed
Sep 18, 2023
zepatrik
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ory-corp/cloud/issues/5319