Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where handlers are tested #407

Closed
aeneasr opened this issue Jan 25, 2021 · 0 comments
Closed

Clarify where handlers are tested #407

aeneasr opened this issue Jan 25, 2021 · 0 comments
Assignees
Labels
bug Something is not working. corp/m5 Up for M5 at Ory Corp.

Comments

@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Is your feature request related to a problem? Please describe.

Currently, handlers do not have any tests. I assume that these are done as part of the e2e tests. However, that makes it a bit difficult to understand what is tested where and how.

If tests are to remain in e2e, there should be at least a test stub in handler_test explaining where the test can be found. In my opinion, e2e tests do not replace proper integration testing and handlers should have their own tests also. They can re-use code if need be.

@aeneasr aeneasr added bug Something is not working. corp/m5 Up for M5 at Ory Corp. labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. corp/m5 Up for M5 at Ory Corp.
Projects
None yet
Development

No branches or pull requests

2 participants