Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keto can not be consumed as a dependency #64

Closed
RomanMinkin opened this issue Dec 5, 2018 · 11 comments
Closed

Keto can not be consumed as a dependency #64

RomanMinkin opened this issue Dec 5, 2018 · 11 comments

Comments

@RomanMinkin
Copy link
Contributor

Describe the bug
keto@v1.0.0-beta.7 can not be resolved as a dependency to another project with both dep or go mod due to Gopkg.lock containing outdated and unused dependencies.

To Reproduce

# with go mod
$ go get github.com/ory/keto@v1.0.0-beta.7

go build github.com/ory/go-convenience/corsx: no Go files in
go build github.com/ory/ladon/manager/sql: no Go files in

Expected behavior
Dependency resolution should pass

@RomanMinkin RomanMinkin mentioned this issue Dec 5, 2018
6 tasks
@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2018

I'm actually able to run go dep just fine:

dep ensure -vendor-only

Make sure you're actually following "Building from source" and don't enable go modules, as the current master is not go modules ready (this will be done with #48)

@RomanMinkin
Copy link
Contributor Author

Hi @aeneasr, we use/import keto as a dependency in go (sdk and some minor data structs), so we need it to be resolved with package manager.

p.s. testing the building option you provided, but it might solve only 50% of the issue.

@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2018

Are you importing the SDK?

@RomanMinkin RomanMinkin changed the title Keto ca not be consumed as a dependency Keto can not be consumed as a dependency Dec 6, 2018
@RomanMinkin
Copy link
Contributor Author

@aeneasr correct, it's actually

import (
	"github.com/ory/keto/authentication"
	"github.com/ory/keto/sdk/go/keto"
	"github.com/ory/keto/sdk/go/keto/swagger"
)

@RomanMinkin
Copy link
Contributor Author

@aeneasr we found a temporary solution by combining PR #65 and adding following to go.mod

module my-package

require (
    github.com/ory/keto v1.0.0-beta.9
)

replace github.com/ory/keto => github.com/RomanMinkin/keto v1.0.0-beta.9.2

@aeneasr
Copy link
Member

aeneasr commented Dec 7, 2018

By the way, I'm hitting the same issue now with oathkeeper. I hope to have it resolved by next week!

@aeneasr
Copy link
Member

aeneasr commented Dec 7, 2018

#48 is now merged! :)

@aeneasr aeneasr closed this as completed Dec 7, 2018
@RomanMinkin
Copy link
Contributor Author

@aeneasr awesome! Thank you for the fast resolution!

@sum2000
Copy link
Contributor

sum2000 commented Dec 7, 2018

@aeneasr Great! I will test them soon!

@aeneasr
Copy link
Member

aeneasr commented Dec 7, 2018

Make sure to read https://github.com/ory/keto/blob/master/UPGRADE.md#010-sandbox as there have been some changes. But the core concepts are still the same!

@aeneasr
Copy link
Member

aeneasr commented Dec 7, 2018

For docs, you can go - for now - here: https://github.com/ory/docs/tree/master/docs/keto/next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants