Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read relation tuples must require namspace query parameter only #760

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

jan-moxter
Copy link
Contributor

The API spec is created automatically from code comments. By reusing the queryRelationTuple from transact_server.go in read_server.go the query parameters object and relation where marked required. This PR copies the queryRelationTuple to read_server.go and removes the required.
The spec where recreated by running make sdk

Related issue(s)

Checklist

Further Comments

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you 👍
The namespace should also not be required as far as I can tell from the code, but I think that needs some update to the docs as well so tracking as an individual issue #761

@zepatrik zepatrik merged commit ba1bec9 into ory:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants