feat: switch to otelx #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icyphox
force-pushed
the
feat/open-telemetry
branch
from
9ebc20a
to
a9a3cd8
Compare
aeneasr
requested changes
Apr 14, 2022
There was a problem hiding this comment.
Please update the tracing example (if required): https://github.com/ory/keto/blob/master/docker-compose-tracing.yml
and also add a guide to show how to do tracing either under the keto guides section: https://www.ory.sh/docs/keto
icyphox
force-pushed
the
feat/open-telemetry
branch
from
bb3d2a2
to
0e8ba15
Compare
|
@aeneasr The tracing in Keto isn't complete yet; I think I'll add the docs for it once I start working on in-depth tracing in Keto. |
|
Ok :) Should we mark this PR as draft then? |
icyphox
force-pushed
the
feat/open-telemetry
branch
from
03a9c17
to
55fbd8a
Compare
|
@icyphox is this the version you use in cloud? |
|
@aeneasr yes. |
aeneasr
force-pushed
the
feat/open-telemetry
branch
from
55fbd8a
to
4c49cca
Compare
4 tasks
zepatrik
reviewed
May 12, 2022
go.mod
Outdated
| go.opentelemetry.io/otel/metric v0.27.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.6.3 // indirect | ||
| go.opentelemetry.io/otel/trace v1.6.3 // indirect | ||
| golang.org/x/crypto v0.0.0-20210921155107-089bfa567519 // indirect |
There was a problem hiding this comment.
I guess this needs to be reverted/adjusted.
zepatrik
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: This patch group updates the tracing provider from OpenTracing to OpenTelemetry. Due to these changes, tracing providers Zipkin, DataDog, Elastic APM have been deactivated temporarily. The best way to re-add support for them is to make a pull request at https://github.com/ory/x/tree/master/otelx and check the status of ory/x#499
The configuration has not changed, and thus no changes to your system are required if you use Jaeger.