Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upsert with pre-existing key will causes duplicate records #88

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

minchao
Copy link
Contributor

@minchao minchao commented Feb 26, 2019

Related issue

#80

Proposed changes

Check if key exists before insert or update.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

…e records

Signed-off-by: minchao <minchao.220@gmail.com>
Signed-off-by: minchao <minchao.220@gmail.com>
@aeneasr
Copy link
Member

aeneasr commented Feb 27, 2019

Awesome! Thank you :)

@aeneasr aeneasr merged commit 1cb8a36 into ory:master Feb 27, 2019
@minchao minchao deleted the fix-80 branch February 27, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants