feat: Update ory/x to v0.0.279 and configure new Prometheus metrics #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harnash
force-pushed
the
update_ory_x_prom_metrics
branch
from
c17674d
to
f7a620a
Compare
Codecov Report
@@ Coverage Diff @@
## v8.x #1735 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 260 260
Lines 12691 12691
=======================================
Hits 9394 9394
Misses 2672 2672
Partials 625 625
Continue to review full report at Codecov.
|
|
Thank you, this looks great! I will mark it as approved but not merge it yet as we would like to have another maintenance release of the 0.7 branch first! |
aeneasr
approved these changes
Sep 8, 2021
aeneasr
added a commit
that referenced
this pull request
Oct 12, 2021
This will add new prometheus metrics for Kratos that are more useful for alerting and increase overall observability. BREAKING CHANGES: This patch changes the naming and number of prometheus metrics (see: ory/x#379). In short: all metrics will have now `http_` prefix to conform to Prometheus best practices. Closes #1735
harnash
pushed a commit
to Wikia/kratos
that referenced
this pull request
Oct 21, 2021
This will add new prometheus metrics for Kratos that are more useful for alerting and increase overall observability. BREAKING CHANGES: This patch changes the naming and number of prometheus metrics (see: ory/x#379). In short: all metrics will have now `http_` prefix to conform to Prometheus best practices. Closes ory#1735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add new prometheus metrics for Kratos that are more useful for alerting and increase overall observability.
BREAKING CHANGES: This patch changes the naming and number of prometheus metrics (see: ory/x#379). In short: all metrics will have now
http_prefix to conform to Prometheus best practices.Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.