Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quickstart curl examples #1778

Merged
merged 8 commits into from
Sep 24, 2021
Merged

fix: quickstart curl examples #1778

merged 8 commits into from
Sep 24, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Sep 22, 2021

This PR closes #1635 and we can create a separete issue/pr for a possible playground-based quickstart/tutorial.

  • Changing instances of https://playground.projects.oryapis.com to local kratos
  • Changing the login & registration payload examples so they work correctly.
  • Changing the end section & next steps a bit
    (IMO we dont need to tease adding login with github to the quickstart, when we have a great step-by-step guide based on the quickstart already)

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #1778 (7c54662) into master (b4972b1) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7c54662 differs from pull request most recent head 95abc56. Consider uploading reports for the commit 95abc56 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
- Coverage   74.13%   74.11%   -0.03%     
==========================================
  Files         260      260              
  Lines       12770    12733      -37     
==========================================
- Hits         9467     9437      -30     
+ Misses       2673     2669       -4     
+ Partials      630      627       -3     
Impacted Files Coverage Δ
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️
cmd/daemon/serve.go 83.33% <0.00%> (ø)
schema/schema.go 88.88% <0.00%> (+2.22%) ⬆️
schema/handler.go 93.33% <0.00%> (+8.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4972b1...95abc56. Read the comment docs.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 ❤️

docs/docs/quickstart.mdx Outdated Show resolved Hide resolved
docs/versioned_docs/version-v0.7/quickstart.mdx Outdated Show resolved Hide resolved
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
@vinckr
Copy link
Member Author

vinckr commented Sep 23, 2021

Thanks for the review @zepatrik 👉 😋

@aeneasr aeneasr closed this Sep 23, 2021
@aeneasr
Copy link
Member

aeneasr commented Sep 23, 2021

Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:

$ make format
$ git commit -a -m "styles: format code"
$ git push

Thank you!

@aeneasr aeneasr reopened this Sep 23, 2021
@vinckr
Copy link
Member Author

vinckr commented Sep 24, 2021

Formatted, updated and included a fix for a small typo I found in concept docs.

@zepatrik zepatrik merged commit 6c677c4 into ory:master Sep 24, 2021
@vinckr vinckr deleted the quickstart-fix branch September 24, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure proper playground usage & versioning
3 participants