-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quickstart curl examples #1778
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
- Coverage 74.13% 74.11% -0.03%
==========================================
Files 260 260
Lines 12770 12733 -37
==========================================
- Hits 9467 9437 -30
+ Misses 2673 2669 -4
+ Partials 630 627 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 ❤️
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Thanks for the review @zepatrik 👉 😋 |
Thank you, this looks great! The CI is failing because some files are formatted incorrectly. To format them, run:
Thank you! |
Formatted, updated and included a fix for a small typo I found in concept docs. |
This PR closes #1635 and we can create a separete issue/pr for a possible playground-based quickstart/tutorial.
https://playground.projects.oryapis.com
to local kratos(IMO we dont need to tease adding login with github to the quickstart, when we have a great step-by-step guide based on the quickstart already)