-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in docker debug support #1789
Conversation
Thank you! Maybe it makes sense to move this to |
You're welcome. :) Do you mean to move the corresponding code to |
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 260 260
Lines 12770 12770
=======================================
Hits 9465 9465
Misses 2674 2674
Partials 631 631 Continue to review full report at Codecov.
|
@aeneasr : I've added documentation as well as a template file for docker-compose based setups. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The last change would be adding the docs to the sidebar :)
@@ -0,0 +1,138 @@ | |||
# Debugging Kratos in Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Debugging Kratos in Docker | |
--- | |
id: debug-docker-delve-ory-kratos | |
title: Debugging Ory Kratos in Docker with Delve | |
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
🙏 |
There is no related issue. The PR adds the possibility to debug Kratos in Docker. Since my entire local setup is dockerized, I was using this each time I was working on a PR for Kratos. Since I think I'm not the only one having such a setup, I hope the community will find this option useful. If this PR is going to be accepted, I'll extend the documentation on how to make use of it.
Checklist
I have added tests that prove my fix is effective or that my feature works.(No tests possible)