Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OIDC provider field in spec #1809

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

provokateurin
Copy link
Contributor

Related issue(s)

Fixes #1739 for now

Checklist

@provokateurin
Copy link
Contributor Author

Test failure seems unrelated to the changes.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1809 (01996f0) into master (c6aa6b5) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
+ Coverage   74.07%   74.13%   +0.05%     
==========================================
  Files         260      260              
  Lines       12770    12770              
==========================================
+ Hits         9460     9467       +7     
+ Misses       2680     2673       -7     
  Partials      630      630              
Impacted Files Coverage Δ
selfservice/strategy/oidc/strategy_login.go 63.33% <ø> (ø)
selfservice/strategy/oidc/strategy_registration.go 54.34% <ø> (ø)
cmd/courier/watch.go 72.41% <0.00%> (+12.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6aa6b5...01996f0. Read the comment docs.

@aeneasr aeneasr merged commit 11b25de into ory:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec is incorrect
2 participants