Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the invalid links #1868

Merged
merged 1 commit into from
Oct 20, 2021
Merged

docs: fix the invalid links #1868

merged 1 commit into from
Oct 20, 2021

Conversation

emrahcom
Copy link
Contributor

Fix the links which point to http://localhost:3000

Related issue(s)

Checklist

Further Comments

@vinckr
Copy link
Member

vinckr commented Oct 20, 2021

Thanks for catching this @emrahcom.
Can you make the same changes for /docs/docs/quickstart.mdx as well, please?

@emrahcom
Copy link
Contributor Author

Can you make the same changes for /docs/docs/quickstart.mdx as well, please?

This file seems OK

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@aeneasr
Copy link
Member

aeneasr commented Oct 20, 2021

Ah sorry, missed your comment

@aeneasr aeneasr merged commit 6d621ec into ory:master Oct 20, 2021
@emrahcom emrahcom deleted the docs-fix-invalid-links branch December 20, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants