Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing sample app paths to oathkeeper config #2058

Merged
merged 1 commit into from Dec 15, 2021

Conversation

theotherian
Copy link
Contributor

Add "welcome,registration,login,verification" and "**.png" to the paths oathkeeper forwards to self service ui.

Currently the self service UI doesn't work when using quickstart-oathkeeper.yml from https://www.ory.sh/kratos/docs/guides/zero-trust-iap-proxy-identity-access-proxy/. This is due to the paths above missing from the access rules.

Related issue(s)

Fixes #2048

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Add "welcome,registration,login,verification" and "**.png" to the paths oathkeeper forwards to self service ui.
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2021

CLA assistant check
All committers have signed the CLA.

@theotherian theotherian changed the title Add missing sample app paths to oathkeeper config fix: Add missing sample app paths to oathkeeper config Dec 13, 2021
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@aeneasr aeneasr merged commit a527db4 into ory:master Dec 15, 2021
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Add "welcome,registration,login,verification" and "**.png" to the paths oathkeeper forwards to self service ui.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oathkeeper access rules appear to be missing paths to get the UI working with quickstart-oathkeeper
3 participants