Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ID field in VerifiableAddress struct optional #2507

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

atreya2011
Copy link
Contributor

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

I have explained in detail regarding this issue over here: #2506

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2507 (bff2d58) into master (cf63a1c) will increase coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2507      +/-   ##
==========================================
+ Coverage   76.01%   76.57%   +0.55%     
==========================================
  Files         318      317       -1     
  Lines       18507    17636     -871     
==========================================
- Hits        14068    13504     -564     
+ Misses       3488     3193     -295     
+ Partials      951      939      -12     
Impacted Files Coverage Δ
identity/identity_verification.go 68.96% <ø> (ø)
x/provider.go 0.00% <0.00%> (-60.00%) ⬇️
selfservice/hook/session_destroyer.go 60.00% <0.00%> (-13.34%) ⬇️
identity/credentials.go 69.23% <0.00%> (-11.48%) ⬇️
selfservice/strategy/oidc/strategy.go 63.34% <0.00%> (-9.22%) ⬇️
selfservice/strategy/oidc/provider_gitlab.go 74.50% <0.00%> (-6.75%) ⬇️
selfservice/strategy/oidc/provider_apple.go 21.12% <0.00%> (-6.26%) ⬇️
selfservice/flow/login/hook.go 89.01% <0.00%> (-5.81%) ⬇️
selfservice/flow/registration/hook.go 84.15% <0.00%> (-5.77%) ⬇️
selfservice/strategy/oidc/strategy_login.go 67.60% <0.00%> (-5.60%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf63a1c...bff2d58. Read the comment docs.

@atreya2011 atreya2011 changed the title fix: make ID field in VerifiableAddress optional fix: make ID field optional in VerifiableAddress optional Jun 6, 2022
@atreya2011 atreya2011 changed the title fix: make ID field optional in VerifiableAddress optional fix: make ID field in VerifiableAddress optional Jun 7, 2022
@atreya2011 atreya2011 changed the title fix: make ID field in VerifiableAddress optional fix: make ID field in VerifiableAddress struct optional Jun 7, 2022
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should fix the issue, as the ID cannot be se by the client.

@atreya2011
Copy link
Contributor Author

@zepatrik
Thank you for approving the pull request! If possible please squash and merge my PR as my individual commit messages are a bit messed up. Sorry about this! 🙇‍♂️

@aeneasr aeneasr merged commit 0844b47 into ory:master Jun 7, 2022
@aeneasr
Copy link
Member

aeneasr commented Jun 7, 2022

Thank you!

@vinckr
Copy link
Member

vinckr commented Jun 8, 2022

Hello @atreya2011
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

@atreya2011
Copy link
Contributor Author

@aeneasr
Thank you for the quick merge! Looking for to the new patch version soon 🙏🏼

@vinckr
Thank you for the swag! I have mailed you with the subject title Re: Ory Swag for merged PR 2507 🙏🏼

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants