Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve migration status speed #2637

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 1, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

github-actions[bot]
github-actions bot previously approved these changes Aug 1, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍


dashboard

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2637 (22e20fc) into master (4ce9f1e) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2637      +/-   ##
==========================================
+ Coverage   75.20%   75.27%   +0.06%     
==========================================
  Files         295      295              
  Lines       16630    16630              
==========================================
+ Hits        12507    12518      +11     
+ Misses       3166     3158       -8     
+ Partials      957      954       -3     
Impacted Files Coverage Δ
persistence/sql/persister_courier.go 86.76% <0.00%> (-2.95%) ⬇️
courier/courier_dispatcher.go 56.86% <0.00%> (+3.92%) ⬆️
courier/smtp.go 75.00% <0.00%> (+9.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@aeneasr aeneasr merged commit a2e3c41 into master Aug 2, 2022
@aeneasr aeneasr deleted the improve-migrator-status branch August 2, 2022 20:07
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant