Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include flow id in use recovery token query #2679

Merged
merged 8 commits into from
Aug 25, 2022
Merged

fix: include flow id in use recovery token query #2679

merged 8 commits into from
Aug 25, 2022

Conversation

jonas-jonas
Copy link
Contributor

@jonas-jonas jonas-jonas commented Aug 19, 2022

This PR adds the selfservice_recovery_flow_id to the query used when "using" a token in the recovery flow.

This PR also adds a new enum field for identity_recovery_tokens to distinguish the two flows: admin versus self-service recovery.

BREAKING CHANGES: This patch invalidates recovery flows initiated using the Admin API. Please re-generate any admin-generated recovery flows and tokens.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #2679 (45aaf28) into master (1cd2672) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2679   +/-   ##
=======================================
  Coverage   75.14%   75.14%           
=======================================
  Files         293      293           
  Lines       16740    16740           
=======================================
  Hits        12580    12580           
  Misses       3196     3196           
  Partials      964      964           
Impacted Files Coverage Δ
persistence/sql/persister_recovery.go 84.28% <100.00%> (ø)
selfservice/strategy/link/strategy_recovery.go 62.85% <100.00%> (ø)
selfservice/strategy/link/test/persistence.go 100.00% <100.00%> (ø)
selfservice/strategy/link/token_recovery.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review August 23, 2022 09:43
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one question then we're ✅

persistence/sql/persister_recovery.go Show resolved Hide resolved
@aeneasr aeneasr merged commit d56586b into ory:master Aug 25, 2022
@jonas-jonas jonas-jonas deleted the fix/connectFlowIdToRecoveryToken branch August 25, 2022 12:42
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
This PR adds the `selfservice_recovery_flow_id` to the query used when "using" a token in the recovery flow.

This PR also adds a new enum field for `identity_recovery_tokens` to distinguish the two flows: admin versus self-service recovery.

BREAKING CHANGES: This patch invalidates recovery flows initiated using the Admin API. Please re-generate any admin-generated recovery flows and tokens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants