fix: admin recovery CSRF & duplicate form elements #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
commented
Oct 27, 2022
| @@ -134,12 +134,9 @@ func TestAdminStrategy(t *testing.T) { | |||
|
|
|||
| action := gjson.GetBytes(body, "ui.action").String() | |||
| require.NotEmpty(t, action) | |||
| csrfToken := gjson.GetBytes(body, "ui.nodes.#(attributes.name==csrf_token).attributes.value").String() | |||
There was a problem hiding this comment.
These assertions are nonsensical in admin flows, as we don't (read can't) enforce anti-CSRF measures on admin flows. So I removed them.
These worked in the first place because the test setup uses the same client for admin actions as for the self-service actions.
Codecov Report
@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
- Coverage 75.96% 75.95% -0.01%
==========================================
Files 304 304
Lines 18168 18173 +5
==========================================
+ Hits 13802 13804 +2
- Misses 3307 3310 +3
Partials 1059 1059
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another quick fix for issues I noticed during example making
Related issue(s)
#2845
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments