Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinguish credential types properly when collecting identifiers #2873

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Nov 8, 2022

closes #2872

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #2873 (ea4571b) into master (9eeedc0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2873      +/-   ##
==========================================
+ Coverage   75.92%   76.01%   +0.08%     
==========================================
  Files         303      303              
  Lines       18249    18251       +2     
==========================================
+ Hits        13856    13873      +17     
+ Misses       3326     3314      -12     
+ Partials     1067     1064       -3     
Impacted Files Coverage Δ
identity/extension_credentials.go 100.00% <100.00%> (ø)
persistence/sql/persister_courier.go 86.86% <0.00%> (+4.04%) ⬆️
courier/courier_dispatcher.go 72.88% <0.00%> (+18.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zepatrik zepatrik merged commit 705f7b1 into master Nov 8, 2022
@zepatrik zepatrik deleted the fix/webauthn-identifier branch November 8, 2022 14:28
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identities created through admin API do not always get password and webauthn identifiers reserved
2 participants