Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not double-commit webhooks on registration #2888

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 14, 2022

See https://github.com/ory-corp/cloud/issues/3360

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2888 (e7ffa83) into master (b1ff220) will decrease coverage by 0.05%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
- Coverage   75.95%   75.90%   -0.06%     
==========================================
  Files         303      304       +1     
  Lines       18296    18319      +23     
==========================================
+ Hits        13897    13905       +8     
- Misses       3330     3342      +12     
- Partials     1069     1072       +3     
Impacted Files Coverage Δ
cmd/cliclient/client.go 35.71% <0.00%> (-9.75%) ⬇️
cmd/identities/definitions.go 71.42% <ø> (ø)
cmd/identities/validate.go 62.66% <0.00%> (ø)
examples/go/pkg/common.go 58.62% <ø> (ø)
identity/identity.go 89.94% <ø> (ø)
hydra/fake.go 37.50% <66.66%> (ø)
cmd/identities/delete.go 94.87% <100.00%> (ø)
cmd/identities/get.go 90.19% <100.00%> (ø)
cmd/identities/import.go 76.47% <100.00%> (ø)
cmd/identities/list.go 81.81% <100.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 88e75d9 into master Nov 14, 2022
@aeneasr aeneasr deleted the fix-double-webhook branch November 14, 2022 13:52
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant