Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused x-session-cookie parameter #2983

Merged
merged 1 commit into from Dec 26, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 25, 2022

This patch removes the undocumented and experimental X-Session-Cookie header from the /sessions/whoami endpoint.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This patch removes the undocumented and experimental `X-Session-Cookie` header from the `/sessions/whoami` endpoint.
@aeneasr aeneasr self-assigned this Dec 25, 2022
@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Merging #2983 (6e0993a) into master (efb8ae8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2983      +/-   ##
==========================================
- Coverage   76.17%   76.16%   -0.01%     
==========================================
  Files         308      308              
  Lines       18943    18938       -5     
==========================================
- Hits        14429    14424       -5     
  Misses       3394     3394              
  Partials     1120     1120              
Impacted Files Coverage Δ
session/manager_http.go 72.38% <100.00%> (-1.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 56b5c26 into master Dec 26, 2022
@aeneasr aeneasr deleted the remove-x-session-cookie branch December 26, 2022 09:16
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
This patch removes the undocumented and experimental `X-Session-Cookie` header from the `/sessions/whoami` endpoint.
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
This patch removes the undocumented and experimental `X-Session-Cookie` header from the `/sessions/whoami` endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants