Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error message when no session is found #2988

Merged
merged 1 commit into from Dec 27, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 27, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #2988 (81a11c1) into master (0b109cd) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
+ Coverage   75.92%   76.25%   +0.32%     
==========================================
  Files         310      309       -1     
  Lines       19128    19069      -59     
==========================================
+ Hits        14523    14541      +18     
+ Misses       3480     3407      -73     
+ Partials     1125     1121       -4     
Impacted Files Coverage Δ
session/error.go 100.00% <ø> (ø)
session/handler.go 67.94% <100.00%> (ø)
selfservice/strategy/oidc/provider_lark.go
selfservice/strategy/oidc/provider_config.go 34.04% <0.00%> (+1.38%) ⬆️
persistence/sql/persister_courier.go 88.09% <0.00%> (+4.76%) ⬆️
courier/courier_dispatcher.go 59.21% <0.00%> (+15.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 7ad2b97 into master Dec 27, 2022
@aeneasr aeneasr deleted the fix-error-message branch December 27, 2022 13:32
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant