Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token prefixes to session and logout tokens #3132

Merged
merged 3 commits into from Mar 17, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 28, 2023

This feature adds token prefixes to Ory session and logout tokens:

  • ory_st_: Ory session token prefix
  • ory_lt_: Logout token prefix

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #3132 (ca79562) into master (e260fcf) will increase coverage by 0.02%.
The diff coverage is 76.47%.

❗ Current head ca79562 differs from pull request most recent head cc7a9d3. Consider uploading reports for the commit cc7a9d3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3132      +/-   ##
==========================================
+ Coverage   77.64%   77.67%   +0.02%     
==========================================
  Files         317      317              
  Lines       20009    20014       +5     
==========================================
+ Hits        15536    15545       +9     
+ Misses       3284     3280       -4     
  Partials     1189     1189              
Impacted Files Coverage Δ
selfservice/flow/verification/flow.go 92.00% <ø> (ø)
selfservice/flow/verification/handler.go 63.02% <ø> (ø)
selfservice/strategy/oidc/strategy_registration.go 64.81% <63.15%> (ø)
selfservice/flow/registration/hook.go 82.11% <66.66%> (ø)
selfservice/flow/login/handler.go 78.87% <71.42%> (ø)
selfservice/strategy/oidc/strategy.go 63.47% <71.42%> (ø)
cmd/clidoc/main.go 67.90% <100.00%> (ø)
identity/handler.go 85.77% <100.00%> (ø)
selfservice/flow/registration/error.go 69.84% <100.00%> (ø)
session/manager_http.go 75.92% <100.00%> (ø)
... and 2 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This feature adds token prefixes to Ory session and logout tokens:

* `ory_st_`: Ory session token prefix
* `ory_lt_`: Logout token prefix
@aeneasr aeneasr merged commit 8210cd0 into master Mar 17, 2023
24 checks passed
@aeneasr aeneasr deleted the add-token-prefixes branch March 17, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant