Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update access-rules.yml example in contrib to allow more assets #3178

Merged
merged 1 commit into from Mar 22, 2023

Conversation

Rodeoclash
Copy link
Contributor

If you're following the tutorial at https://www.ory.sh/docs/kratos/guides/zero-trust-iap-proxy-identity-access-proxy and using the reference frontend, you'll get broken images and fonts when loading the login (and other) pages.

This simply allows the other assets that the reference frontend uses to be loaded via the proxy without error.

Related issue(s)

No related issues as far as I can tell.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

If you're following the tutorial at https://www.ory.sh/docs/kratos/guides/zero-trust-iap-proxy-identity-access-proxy and using the reference frontend, you'll get broken images and fonts.

This simply allows the other assets that the reference frontend uses to be loaded via the proxy without error.
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2023

CLA assistant check
All committers have signed the CLA.

@Rodeoclash Rodeoclash changed the title Update access-rules.yml improvement: Update access-rules.yml example in contrib to allow more assets Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3178 (7f6131d) into master (5403f86) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 7f6131d differs from pull request most recent head 5af0c3f. Consider uploading reports for the commit 5af0c3f to get more accurate results

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   77.73%   77.70%   -0.03%     
==========================================
  Files         317      317              
  Lines       20046    20046              
==========================================
- Hits        15583    15577       -6     
- Misses       3275     3279       +4     
- Partials     1188     1190       +2     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas jonas-jonas changed the title improvement: Update access-rules.yml example in contrib to allow more assets chore: Update access-rules.yml example in contrib to allow more assets Mar 21, 2023
Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, LGTM.

@jonas-jonas jonas-jonas changed the title chore: Update access-rules.yml example in contrib to allow more assets chore: update access-rules.yml example in contrib to allow more assets Mar 21, 2023
@aeneasr aeneasr merged commit a206772 into ory:master Mar 22, 2023
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants