Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor refactorings in package hash #3186

Merged
merged 4 commits into from May 24, 2023

Conversation

ci42
Copy link
Contributor

@ci42 ci42 commented Mar 23, 2023

  • removed duplicated code for constant time hash comparison
  • removed unnecessary type conversions
  • always return the same error value if hash and password don't match(hash.ErrMismatchedHashAndPassword)

Checklist

@ci42 ci42 changed the title minor refactorings in package hash refactor: minor refactorings in package hash Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3186 (7ea7315) into master (5535fcb) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head 7ea7315 differs from pull request most recent head f29dbd0. Consider uploading reports for the commit f29dbd0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
- Coverage   78.13%   77.89%   -0.24%     
==========================================
  Files         325      320       -5     
  Lines       20811    20466     -345     
==========================================
- Hits        16260    15943     -317     
+ Misses       3340     3324      -16     
+ Partials     1211     1199      -12     
Impacted Files Coverage Δ
hash/hash_comparator.go 85.56% <100.00%> (-0.06%) ⬇️
hash/hasher_argon2.go 70.37% <100.00%> (ø)

... and 34 files with indirect coverage changes

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@aeneasr aeneasr merged commit 831fb19 into ory:master May 24, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants