Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e account experience redirects to verification page #3195

Merged
merged 1 commit into from Apr 3, 2023

Conversation

Benehiko
Copy link
Contributor

Related issue(s)

When account verification is required for login, the UI will instead redirect to the verification UI with the error message.

ory/kratos-selfservice-ui-node#253

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@Benehiko Benehiko changed the title fix(e2e): account experience redirects to verification page fix: e2e account experience redirects to verification page Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #3195 (d3d4ce2) into master (08a3447) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d3d4ce2 differs from pull request most recent head a4cb24e. Consider uploading reports for the commit a4cb24e to get more accurate results

@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
+ Coverage   77.68%   77.71%   +0.02%     
==========================================
  Files         319      319              
  Lines       20162    20162              
==========================================
+ Hits        15663    15669       +6     
+ Misses       3301     3296       -5     
+ Partials     1198     1197       -1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Benehiko Benehiko self-assigned this Mar 31, 2023
Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aeneasr aeneasr merged commit 2e96d75 into master Apr 3, 2023
28 of 29 checks passed
@aeneasr aeneasr deleted the fix-e2e-verified-account branch April 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants