Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqa config values unified across projects #3237

Merged
merged 1 commit into from Apr 17, 2023

Conversation

misamu
Copy link
Contributor

@misamu misamu commented Apr 14, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3237 (b7667e6) into master (c15de85) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b7667e6 differs from pull request most recent head 5d5a847. Consider uploading reports for the commit 5d5a847 to get more accurate results

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   77.89%   77.92%   +0.03%     
==========================================
  Files         319      319              
  Lines       20431    20435       +4     
==========================================
+ Hits        15914    15924      +10     
+ Misses       3317     3312       -5     
+ Partials     1200     1199       -1     
Impacted Files Coverage Δ
cmd/daemon/serve.go 89.23% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 523b93f into ory:master Apr 17, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants