Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle 'prompt' upstream parameter during OIDC flow #3276

Merged
merged 2 commits into from May 25, 2023

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented May 12, 2023

Documentation:

Documentation added here: ory/docs#1410

Related issue(s)

Fixes #2709

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr
Copy link
Member

aeneasr commented May 24, 2023

Thank you! I reversed the order to ensure that prompt from user-provided values never overwrite prompt set by Kratos' business logic!

@David-Wobrock
Copy link
Contributor Author

Thank you! I reversed the order to ensure that prompt from user-provided values never overwrite prompt set by Kratos' business logic!

Awesome! Thanks for that 🙇

@aeneasr aeneasr merged commit d290cb0 into ory:master May 25, 2023
27 checks passed
@David-Wobrock David-Wobrock deleted the feat/prompt-upstream-param branch May 25, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for "prompt=select_account" when using social sign-in
2 participants