Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cookie for updateLogoutFlow #3284

Merged
merged 1 commit into from May 24, 2023

Conversation

PhakornKiong
Copy link
Contributor

@PhakornKiong PhakornKiong commented May 16, 2023

Related issue(s)

ory/sdk#255 updateLogOutFlow for go SDK doesn't work because there is no way to pass cookie.

Also reported in slack
https://ory-community.slack.com/archives/C02MR4DEEGH/p1683790647078969

Follow #2454 for fixing

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

It is blocking my team from implementing logout, appreciate if this could be fix

@CLAassistant
Copy link

CLAassistant commented May 16, 2023

CLA assistant check
All committers have signed the CLA.

@PhakornKiong PhakornKiong changed the title add cookie for updateLogoutFlow fix: add cookie for updateLogoutFlow May 16, 2023
Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Great find and fix.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 95ed2b9 into ory:master May 24, 2023
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants