Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve event types and capture more events #3297

Merged
merged 3 commits into from May 31, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 31, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner May 31, 2023 09:33
jonas-jonas
jonas-jonas previously approved these changes May 31, 2023
Copy link
Contributor

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

selfservice/flow/login/hook.go Outdated Show resolved Hide resolved
identity/manager.go Show resolved Hide resolved
selfservice/flow/registration/hook.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member Author

aeneasr commented May 31, 2023

Whoops, how did this end up with the wrong PR

@aeneasr aeneasr changed the title Feature/core 2073 feat: improve event types and capture more events May 31, 2023
jonas-jonas
jonas-jonas previously approved these changes May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #3297 (a13e32e) into master (8ae8783) will increase coverage by 0.14%.
The diff coverage is 98.59%.

❗ Current head a13e32e differs from pull request most recent head 6fe3792. Consider uploading reports for the commit 6fe3792 to get more accurate results

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   77.57%   77.71%   +0.14%     
==========================================
  Files         325      325              
  Lines       20570    20695     +125     
==========================================
+ Hits        15958    16084     +126     
  Misses       3385     3385              
+ Partials     1227     1226       -1     
Impacted Files Coverage Δ
selfservice/hook/session_issuer.go 79.41% <ø> (-0.59%) ⬇️
selfservice/strategy/oidc/strategy_login.go 67.05% <0.00%> (ø)
identity/manager.go 79.83% <66.66%> (-0.35%) ⬇️
selfservice/flow/login/error.go 70.76% <100.00%> (+0.45%) ⬆️
selfservice/flow/login/handler.go 79.20% <100.00%> (ø)
selfservice/flow/login/hook.go 85.03% <100.00%> (+0.36%) ⬆️
selfservice/flow/recovery/error.go 81.66% <100.00%> (+0.63%) ⬆️
selfservice/flow/recovery/hook.go 90.00% <100.00%> (+0.25%) ⬆️
selfservice/flow/registration/error.go 68.57% <100.00%> (+0.45%) ⬆️
selfservice/flow/registration/hook.go 70.92% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 835fe13 into master May 31, 2023
28 checks passed
@aeneasr aeneasr deleted the feature/core-2073 branch May 31, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants