Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ory/x #3304

Merged
merged 4 commits into from Jun 7, 2023
Merged

fix: update ory/x #3304

merged 4 commits into from Jun 7, 2023

Conversation

IchordeDionysos
Copy link
Contributor

This PR fixes #3244, which fails to add a field to metadata_public/metadata_admin when nothing yet exists in that object / when the objects are null.

The root cause has been fixed here ory/x#692

Related issue(s)

#3244
https://ory-community.slack.com/archives/C012USDT5QQ/p1685968287885839

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

jonas-jonas
jonas-jonas previously approved these changes Jun 6, 2023
@IchordeDionysos IchordeDionysos changed the title Update ory-x to latest version chore: update ory/x to latest version Jun 6, 2023
@IchordeDionysos IchordeDionysos changed the title chore: update ory/x to latest version fix: update ory/x Jun 6, 2023
cmd/daemon/serve.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Jun 7, 2023

Thank you! We'll get the metrics PR merged first, then this one :)

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #3304 (9a55f67) into master (98fe73f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9a55f67 differs from pull request most recent head e619c8b. Consider uploading reports for the commit e619c8b to get more accurate results

@@            Coverage Diff             @@
##           master    #3304      +/-   ##
==========================================
+ Coverage   78.07%   78.08%   +0.01%     
==========================================
  Files         325      325              
  Lines       21054    21054              
==========================================
+ Hits        16437    16441       +4     
+ Misses       3388     3386       -2     
+ Partials     1229     1227       -2     

see 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 3c04d8f into ory:master Jun 7, 2023
18 of 19 checks passed
@IchordeDionysos IchordeDionysos deleted the fix/update-object-field-when-object-null branch June 8, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't patch metadata if metadata is null
3 participants