Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook config parse for settings flow #3305

Merged
merged 4 commits into from Jun 14, 2023

Conversation

jossbnd
Copy link
Contributor

@jossbnd jossbnd commented Jun 6, 2023

Related issue(s)

#3252

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3305 (b43c50c) into master (950b41a) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head b43c50c differs from pull request most recent head a70dc82. Consider uploading reports for the commit a70dc82 to get more accurate results

@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
- Coverage   78.09%   78.08%   -0.02%     
==========================================
  Files         325      325              
  Lines       21092    21054      -38     
==========================================
- Hits        16471    16439      -32     
+ Misses       3391     3388       -3     
+ Partials     1230     1227       -3     

see 3 files with indirect coverage changes

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests to web_hook_integrations? Probably just a bit of copy & paste :)

@jossbnd jossbnd requested a review from aeneasr June 12, 2023 09:59
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 95ad94d into ory:master Jun 14, 2023
26 checks passed
@jossbnd jossbnd deleted the fix-parse-config-on-flow-settings branch June 14, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants