Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add return_to parameters to the createLogout handler #3336

Merged
merged 5 commits into from Jun 29, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Jun 21, 2023

Related issue(s)

#3100

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #3336 (8546e19) into master (ce20063) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 8546e19 differs from pull request most recent head 0bc7cf0. Consider uploading reports for the commit 0bc7cf0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
+ Coverage   77.93%   77.97%   +0.03%     
==========================================
  Files         326      326              
  Lines       21204    21219      +15     
==========================================
+ Hits        16526    16545      +19     
+ Misses       3446     3444       -2     
+ Partials     1232     1230       -2     
Impacted Files Coverage Δ
selfservice/flow/logout/handler.go 81.31% <100.00%> (+3.68%) ⬆️

... and 1 file with indirect coverage changes

@Benehiko Benehiko marked this pull request as ready for review June 29, 2023 10:55
@Benehiko Benehiko merged commit 08fed36 into master Jun 29, 2023
28 checks passed
@Benehiko Benehiko deleted the feat-logout-return-to branch June 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants