Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return the updated identity as described in the API spec #3347

Merged
merged 1 commit into from Jun 27, 2023

Conversation

borisroman
Copy link
Contributor

@borisroman borisroman commented Jun 26, 2023

Related issue(s)

Fixes #3346

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3347 (0e95ace) into master (adf78e0) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e95ace differs from pull request most recent head 8af257e. Consider uploading reports for the commit 8af257e to get more accurate results

@@           Coverage Diff           @@
##           master    #3347   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files         324      324           
  Lines       21025    21025           
=======================================
  Hits        16410    16410           
  Misses       3385     3385           
  Partials     1230     1230           
Impacted Files Coverage Δ
identity/handler.go 86.20% <ø> (ø)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please instead change https://github.com/ory/kratos/pull/3347/files#diff-461d37b91ce0b27e82db7c21166a58a7f8bea1446854e488822f8b79ad95a4e6R904 to

204: emptyResponse

Thank you! :)

@borisroman borisroman force-pushed the fix/deleteIdentityCredentials branch from 0862ef2 to 8af257e Compare June 27, 2023 06:27
@borisroman
Copy link
Contributor Author

@aeneasr Changed the commit to reflect the requested changes.

Thanks again for the quick response.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit f3dee86 into ory:master Jun 27, 2023
26 checks passed
@borisroman borisroman deleted the fix/deleteIdentityCredentials branch June 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API call /admin/identities/{id}/credentials/{type} doesn't return expected statuscode and body
2 participants