Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate SessionIssued event #3351

Merged
merged 2 commits into from Jul 4, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 27, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner June 27, 2023 13:19
jonas-jonas
jonas-jonas previously approved these changes Jun 27, 2023
@aeneasr aeneasr changed the title fix: remoev duplicate SessionIssued event fix: remove duplicate SessionIssued event Jun 27, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3351 (7301b12) into master (f884dfb) will increase coverage by 0.10%.
The diff coverage is 78.57%.

❗ Current head 7301b12 differs from pull request most recent head cb47abc. Consider uploading reports for the commit cb47abc to get more accurate results

@@            Coverage Diff             @@
##           master    #3351      +/-   ##
==========================================
+ Coverage   77.82%   77.92%   +0.10%     
==========================================
  Files         325      326       +1     
  Lines       21086    21185      +99     
==========================================
+ Hits        16410    16509      +99     
  Misses       3446     3446              
  Partials     1230     1230              
Impacted Files Coverage Δ
identity/handler.go 86.20% <ø> (ø)
selfservice/flow/login/handler.go 79.38% <ø> (ø)
selfservice/flow/logout/handler.go 77.63% <ø> (ø)
selfservice/strategy/code/strategy_recovery.go 70.56% <ø> (ø)
session/manager.go 100.00% <ø> (ø)
selfservice/flow/settings/handler.go 68.38% <60.00%> (ø)
session/manager_http.go 77.47% <77.77%> (-0.61%) ⬇️
selfservice/flow/login/hook.go 86.61% <80.00%> (ø)
selfservice/flow/settings/error.go 77.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit b1e78ad into master Jul 4, 2023
20 of 21 checks passed
@aeneasr aeneasr deleted the fix-session-changed branch July 4, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants