Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install kratos-selfservice-ui-node peer deps #3354

Merged
merged 1 commit into from Jun 29, 2023
Merged

fix: install kratos-selfservice-ui-node peer deps #3354

merged 1 commit into from Jun 29, 2023

Conversation

Benehiko
Copy link
Contributor

@Benehiko Benehiko commented Jun 29, 2023

Related issue(s)

The @ory/integrations package has a peer dependency on @ory/client. But since we use the AX to test Kratos we sometimes need the @ory/client to be generated based on an open PR in Kratos. This then creates versions such as v1.1.39-alpha.0. The @ory/integrations package uses a version >= v1.1.39 which means that our alpha version is less (<) than the required.

We have a couple of options:

  1. Remove the peer dependency requirement from @ory/integrations.
  2. Make it more lax in version numbers >=v1.1.30
  3. Install peer deps with --legacy-peer-deps

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@Benehiko Benehiko marked this pull request as ready for review June 29, 2023 09:44
@Benehiko Benehiko changed the title fix(e2e): install kratos-selfservice-ui-node peer deps fix: install kratos-selfservice-ui-node peer deps Jun 29, 2023
@Benehiko Benehiko force-pushed the fix-e2e branch 2 times, most recently from 6ac673a to 1a15307 Compare June 29, 2023 10:02
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3354 (de89d1a) into master (0ed1abd) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head de89d1a differs from pull request most recent head 1a15307. Consider uploading reports for the commit 1a15307 to get more accurate results

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   77.93%   78.03%   +0.09%     
==========================================
  Files         326      326              
  Lines       21204    21204              
==========================================
+ Hits        16526    16546      +20     
+ Misses       3447     3431      -16     
+ Partials     1231     1227       -4     

see 3 files with indirect coverage changes

@Benehiko Benehiko merged commit ce20063 into master Jun 29, 2023
28 checks passed
@Benehiko Benehiko deleted the fix-e2e branch June 29, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants