Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Created required directories during install #750

Closed
wants to merge 1 commit into from

Conversation

leadiato
Copy link

@leadiato leadiato commented Oct 7, 2020

Related issue

#711

Describe Issue:

Following Kratos Building from source instructions to build after cloning the repo fails with the error:
make: *** No rule to make target '.bin/packr2', needed by 'install'. Stop.

Proposed changes

I'm creating the 2 required directories as part of make install

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.
    (No documentation added since the documentation is not listing those directories as pre requisite)

Not sure how to write test for this change (it's my first time working with make).

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2020

CLA assistant check
All committers have signed the CLA.

@leadiato leadiato changed the title Created required directories during install build: Created required directories during install Oct 7, 2020
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. Here you would create two directories, but what we want is to run the two makefile tasks .bin/packr2 and ./bin/pack which installs two binaries packr2 and packr into the .bin directory. Can you please detail your issue in the original thread? With error outputs etc. Thanks!

@aeneasr aeneasr closed this in ec6e664 Oct 11, 2020
aeneasr added a commit that referenced this pull request Oct 11, 2020
aeneasr added a commit that referenced this pull request Oct 13, 2020
aeneasr added a commit that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants