Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfinished sentence in README #116

Closed
ucarion opened this issue Jul 2, 2018 · 1 comment
Closed

Unfinished sentence in README #116

ucarion opened this issue Jul 2, 2018 · 1 comment

Comments

@ucarion
Copy link

ucarion commented Jul 2, 2018

Hi y'all! I'd open a PR for this, but I'm genuinely unsure as to what the meaning of the last sentence of this paragraph, taken from the README, is supposed to be:

You will get the best performance with the in-memory manager. The SQL adapters perform about 1000:1 compared to the in-memory solution. Please note that these tests where in laboratory environments with Docker, without an SSD, and single-threaded. You might get better results on your system. We are thinking about introducing It would be possible a simple cache strategy such as LRU with a maximum age to further reduce runtime complexity.

@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2018

Yeah, that should read:

You will get the best performance with the in-memory manager. The SQL adapters perform about 1000:1 compared to the in-memory solution. Please note that these tests where in laboratory environments with Docker, without an SSD, and single-threaded. You might get better results on your system. We are thinking about introducing other matching strategies (e.g. wildcard instead of regex) and also introducing simple cache strategies such as LRU with a maximum age to further reduce runtime complexity.

@aeneasr aeneasr closed this as completed in 469ee7d Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants