Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlx requirement for sql manager #80

Closed
zikes opened this issue Aug 15, 2017 · 3 comments
Closed

sqlx requirement for sql manager #80

zikes opened this issue Aug 15, 2017 · 3 comments

Comments

@zikes
Copy link
Contributor

zikes commented Aug 15, 2017

In the documentation (https://github.com/ory/ladon#persistence) the SQL example shows a database connection created using stdlib's sql.Open, however the ladon/manager/sql NewSQLManager function lists the first argument as db *sqlx.DB. As a result, when a standard *sql.DB is passed in, this error is given:

cannot use ladonDb (type *"database/sql".DB) as type *sqlx.DB in argument to "github.com/ory/ladon/manager/sql".NewSQLManager
@wirepair
Copy link
Contributor

wirepair commented Jul 4, 2018

I realize this is closed, but I ran into the same thing, so I wrote my own SQLManager https://github.com/wirepair/ladonsqlmanager that removes the migration/sqlx dependencies. It requires you to manage the tables externally (which is what i want to do anyways).

@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2018

Nice, if you want, you can add it to the readme at the bottom under a new section "3rd Party Libraries" :)

@wirepair
Copy link
Contributor

wirepair commented Jul 4, 2018

Done :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants