Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow otel tracing provider in config #1039

Merged
merged 2 commits into from Dec 1, 2022

Conversation

jgraeger
Copy link
Contributor

@jgraeger jgraeger commented Nov 25, 2022

This PR aims to allow usage of the open telemetry tracing provider of ory/x in oathkeeper. As ory/x has been updated to a recent version in #999, this came down to a small change in the configuration schema.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2022

CLA assistant check
All committers have signed the CLA.

@jgraeger jgraeger changed the title Allow otel tracing provider in config fix: Allow otel tracing provider in config Nov 25, 2022
@jgraeger jgraeger changed the title fix: Allow otel tracing provider in config fix: allow otel tracing provider in config Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1039 (195462b) into master (f363b3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1039   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files          83       83           
  Lines        3869     3869           
=======================================
  Hits         3045     3045           
  Misses        554      554           
  Partials      270      270           
Impacted Files Coverage Δ
api/decision.go 95.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 2661190 into ory:master Dec 1, 2022
@jgraeger jgraeger deleted the fix/otel-support branch December 1, 2022 11:59
@vinckr
Copy link
Member

vinckr commented Dec 1, 2022

Hello @jgraeger
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oathkeeper does not respect TRACING_PROVIDER=otel
4 participants