Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward config options in middleware #1062

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Feb 7, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner February 7, 2023 14:00
@hperl hperl self-assigned this Feb 7, 2023
@hperl hperl requested a review from zepatrik February 7, 2023 14:00
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1062 (831de2c) into master (e1357f8) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
- Coverage   78.16%   78.12%   -0.05%     
==========================================
  Files          83       83              
  Lines        4008     4013       +5     
==========================================
+ Hits         3133     3135       +2     
- Misses        596      599       +3     
  Partials      279      279              
Impacted Files Coverage Δ
driver/registry_memory.go 89.82% <0.00%> (ø)
middleware/definitions.go 73.52% <66.66%> (-5.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zepatrik zepatrik merged commit f3c4386 into master Feb 7, 2023
@zepatrik zepatrik deleted the hperl/middleware-config-options branch February 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants