Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render complete config schema in CI and update tracing config+instrumentation #1063

Merged
merged 2 commits into from Feb 8, 2023

Conversation

alnr
Copy link
Collaborator

@alnr alnr commented Feb 7, 2023

No description provided.

@alnr alnr self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1063 (86d3b8e) into master (7e7d45e) will increase coverage by 0.33%.
The diff coverage is 100.00%.

❗ Current head 86d3b8e differs from pull request most recent head 3138b2b. Consider uploading reports for the commit 3138b2b to get more accurate results

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
+ Coverage   77.79%   78.12%   +0.33%     
==========================================
  Files          81       82       +1     
  Lines        3967     3995      +28     
==========================================
+ Hits         3086     3121      +35     
+ Misses        600      597       -3     
+ Partials      281      277       -4     
Impacted Files Coverage Δ
...peline/authn/authenticator_oauth2_introspection.go 80.00% <100.00%> (-0.22%) ⬇️
cmd/root.go 15.38% <0.00%> (-13.19%) ⬇️
driver/registry_memory.go 89.82% <0.00%> (-0.68%) ⬇️
driver/registry.go 100.00% <0.00%> (ø)
cmd/health_ready.go 77.77% <0.00%> (ø)
pipeline/authz/remote.go 71.95% <0.00%> (ø)
middleware/definitions.go 73.52% <0.00%> (ø)
pipeline/authz/remote_json.go 88.05% <0.00%> (ø)
driver/health/event_manager_default.go 94.11% <0.00%> (ø)
rule/readiness/rule_readiness.go 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Let me know when it is ready to review.

@alnr alnr marked this pull request as ready for review February 7, 2023 18:41
@alnr alnr requested a review from aeneasr as a code owner February 7, 2023 18:41
@alnr
Copy link
Collaborator Author

alnr commented Feb 7, 2023

Nice 👍 Let me know when it is ready to review.

Should be good to review. I want to merge this after #1056.

@aeneasr aeneasr merged commit e5e9d17 into master Feb 8, 2023
@aeneasr aeneasr deleted the tracing-config-schema branch February 8, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants