Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add http method into session.MatchContext #676

Merged

Conversation

corrideat
Copy link
Contributor

@corrideat corrideat commented Mar 23, 2021

Related issue

#625

Proposed changes

The HTTP Request method becomes available in MatchContext, so that it may be used in templates.

Checklist

<!-
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
-->

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@corrideat corrideat changed the title Issue #625: Add http method into session.MatchContext feat: Add http method into session.MatchContext Mar 23, 2021
@aeneasr aeneasr merged commit e15a7a5 into ory:master Mar 24, 2021
@robbietree8
Copy link

Does the docker image containing this patch published to docker hub?
Currently, the latest docker tag points to v0.38.9.

@aeneasr

@aeneasr
Copy link
Member

aeneasr commented May 2, 2021

We have some issues with the CI in Ory Oathkeeper but I probably won't have time this week to look into it. Any contribs welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants