New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump dependencies #999
Conversation
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
===========================================
+ Coverage 66.49% 77.79% +11.30%
===========================================
Files 107 81 -26
Lines 4796 3873 -923
===========================================
- Hits 3189 3013 -176
+ Misses 1325 587 -738
+ Partials 282 273 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, just found some minor things 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First-pass review :)
39920db
to
5ef9120
Compare
25c5629
to
a998323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is basically in a mergable state with a few questions and requirements:
- in
health_test.go
it looks as if the health payloads have changed. If so, we should add this as a breaking change. Can you please update the PR description to match the changes made? - some configuration environment variables have been deprecated, please add those to the breaking changes list above.
- check that the removed env vars are not used in helm charts and in ory cloud
- Search the documentation for removed config keys and remove them
* bump ory/x deps * update to new httpx, metricsx * cleanup viper config
* revert schema * bump swagger * remove extra sets * simplify CORS settings getter * move to resilitent httpx completely
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
80de07c
to
cd272a7
Compare
Done, no references to |
121e3c5
to
f33dce4
Compare
* remove broken caching for e2e tests * re-add `--config` flag
f33dce4
to
78c0acb
Compare
This PR swaps the configuration library from viperx for koanf and updates the dependencies, most importantly to
ory/x
.This work relates to the effort to use Oathkeeper as a gRPC/HTTP middleware in other projects.
Fixes #757
Breaking changes
status
,code
, andmessage
JAEGER_PROPAGATION
was removed. UseTRACING_PROVIDER_JAEGER_PROPAGATION