Skip to content

Commit

Permalink
Distinguish product and test issues bugref
Browse files Browse the repository at this point in the history
Progress is used to track test issues, bugzilla for product issues, at least
for SUSE/openSUSE. This might be a lot different for other groups so a more
flexible approach could be thought of but probably it is not as easy as
just distinguishing on the issue tracker URL being used, e.g. if a group
uses just one issue tracker but different components or issue types to
differentiate, it is not that easy. That is why this simple solution is
done here, first. At least others can follow the approach and have a test
and CSS rule available ;-)
  • Loading branch information
okurz committed Jun 6, 2016
1 parent e23e6f8 commit 869ec10
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions assets/stylesheets/openqa.css
Expand Up @@ -531,6 +531,7 @@ table.overview .failedmodule {
.fa.module_none { color:#bebebe;}

.fa.comment, .fa.bookmark, .fa.bug, .fa.certificate, .fa.tag { color: Grey; }
.fa-bolt { color: #FFBF00; } /* Amber */

table#users td.role {
white-space: nowrap;
Expand Down
6 changes: 6 additions & 0 deletions t/ui/15-comments.t
Expand Up @@ -240,6 +240,12 @@ $get = $t->get_ok($driver->get_current_url())->status_is(200);
is($get->tx->res->dom->at('#res_DVD_x86_64_doc .fa-bug')->parent->{href}, 'https://bugzilla.suse.com/show_bug.cgi?id=1234');
$driver->find_element('opensuse', 'link_text')->click();
is($driver->find_element('.fa-certificate', 'css')->get_attribute('title'), 'Reviewed (1 comments)', 'build should be marked as labeled');
$driver->get($baseurl . 'tests/99926#comments');
$driver->find_element('#text', 'css')->send_keys('poo#9876');
$driver->find_element('#submitComment', 'css')->click();
$driver->find_element('Build87.5011@opensuse', 'link_text')->click();
is($driver->find_element('#res_staging_e_x86_64_minimalx .fa-bolt', 'css')->get_attribute('title'), 'Bug(s) referenced: poo#9876', 'bolt icon shown for progress issues');
$driver->find_element('opensuse', 'link_text')->click();

#
# do tests for editing when logged in as regular user(group overview)
Expand Down
2 changes: 1 addition & 1 deletion templates/test/tr_job_result_details.html.ep
Expand Up @@ -4,7 +4,7 @@
% if ($bug) {
<span id="bug-<%= $jobid %>">
<a href="<%= bugurl_for $bug %>">
<i class="test-label label_bug fa fa-bug" title="Bug(s) referenced: <%= $bug %>"></i>
<i class="test-label label_bug fa <%= $bug =~ /poo#/ ? 'fa-bolt' : 'fa-bug' %>" title="Bug(s) referenced: <%= $bug %>"></i>
</a>
</span>
% }
Expand Down

0 comments on commit 869ec10

Please sign in to comment.