Skip to content

Commit

Permalink
Mojo::URL no longer escapes / in URL
Browse files Browse the repository at this point in the history
  • Loading branch information
aaannz committed Jul 13, 2015
1 parent e83409d commit f03264b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions script/client
Expand Up @@ -118,9 +118,11 @@ for my $arg (@ARGV) {
$method = lc $arg;
}
elsif ($arg =~ /^([[:alnum:]_]+)=(.+)/) {
$params{$1} = $2;
}
else {
my $key = $1;
my $value = $2;
# Mojo::URL no longer escapes / (https://github.com/kraih/mojo/commit/aab2f1f)
$value =~ s@/@%2F@g;
$params{$key} = $value;
}
}

Expand Down

2 comments on commit f03264b

@dzyuzin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit broke posting variables with /.
ADDONURL='http://dist.suse.de/install/SLP/SLE-12-SP1-HA-Beta1/x86_64/DVD1/' becomes ADDONURL='http:%2F%2Fdist.suse.de%2Finstall%2FSLP%2FSLE-12-SP1-HA-Beta1%2Fx86_64%2FDVD1%2F'

@aaannz
Copy link
Contributor Author

@aaannz aaannz commented on f03264b Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. But AFAIK Mojo then converts it back to / once it pass through http. Otherwise request URL contains / which Mojo interpreted as path delimiter and HMAC didn't pass and autentification failed.

Please sign in to comment.