Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: Make log messages about "cache service unavailable" and "webui not available" consistent #3645

Closed
okurz opened this issue Dec 15, 2020 · 1 comment
Assignees

Comments

@okurz
Copy link
Member

okurz commented Dec 15, 2020

Observation

If I start a worker with CACHEDIRECTORY configured but no cache service started (or when it crashed or failed) and multiple web UIs configured I see recurring info/warn messages about the retrying but no information that the cache service connection is retried, e.g.:

[error] Worker cache not available: Cache service info error: Connection refused
[info] CACHE: caching is enabled, setting up /var/lib/openqa/cache/e13.suse.de
[info] Project dir for host e13.suse.de is /var/lib/openqa/share
[info] CACHE: caching is enabled, setting up /var/lib/openqa/cache/yast-openqa.suse.cz
[info] Project dir for host yast-openqa.suse.cz is /var/lib/openqa/share
[info] Registering with openQA e13.suse.de
[warn] Failed to register at e13.suse.de - connection error: No route to host - trying again in 10 seconds
[info] Registering with openQA yast-openqa.suse.cz
[warn] Failed to register at yast-openqa.suse.cz - connection error: Connection refused - trying again in 10 seconds
[info] Registering with openQA e13.suse.de
[warn] Failed to register at e13.suse.de - connection error: No route to host - trying again in 10 seconds
[info] Registering with openQA yast-openqa.suse.cz
[warn] Failed to register at yast-openqa.suse.cz - connection error: Connection refused - trying again in 10 seconds
[info] Registering with openQA e13.suse.de
[warn] Failed to register at e13.suse.de - connection error: No route to host - trying again in 10 seconds
[info] Registering with openQA yast-openqa.suse.cz
[warn] Failed to register at yast-openqa.suse.cz - connection error: Connection refused - trying again in 10 seconds

Suggestion

Likely in

$self->check_availability unless $current_job;

we can handle a false return value of check_availability to log something like log_info "cache service unavailable, retrying in $timeout"

Martchus added a commit to Martchus/openQA that referenced this issue Dec 15, 2020
It will look like this:
```
[warn] Worker cache not available: Cache service info error: Connection refused - checking again for web UI 'http://localhost:9526' in 100.00 s
```

See os-autoinst#3645
@Martchus Martchus self-assigned this Dec 15, 2020
Martchus added a commit to Martchus/openQA that referenced this issue Dec 16, 2020
It will look like this:
```
[warn] Worker cache not available: Cache service info error: Connection refused - checking again for web UI 'http://localhost:9526' in 100.00 s
```

See os-autoinst#3645
@okurz
Copy link
Member Author

okurz commented Dec 17, 2020

Fixed by #3646

@okurz okurz closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants