Add review badge when all jobs passed or reviewed #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement optional task in https://progress.opensuse.org/issues/14934
coolo
reviewed
Dec 5, 2016
| @@ -68,6 +68,8 @@ sub add_review_badge { | |||
| my ($build_res) = @_; | |||
|
|
|||
| $build_res->{reviewed_all_passed} = $build_res->{passed} == $build_res->{total}; | |||
| $build_res->{reviewed_all_passed_or_softfailed} | |||
| = $build_res->{passed} + $build_res->{softfailed} == $build_res->{total}; | |||
There was a problem hiding this comment.
this reviewed_ prefix is actually wrong. There is nothing about reviews in here.
There was a problem hiding this comment.
Think about it as "auto-review" badge. But I can change it if you like. Then I would also change reviewed_all_passed for consistency.
There was a problem hiding this comment.
I disagree that passed tests are auto-reviewed. They are not reviewed at all
|
fine with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement optional task in https://progress.opensuse.org/issues/14934