Adjust grid wrapping in build tables #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
+ Coverage 87.11% 87.19% +0.08%
==========================================
Files 104 104
Lines 7348 7348
==========================================
+ Hits 6401 6407 +6
+ Misses 947 941 -6
Continue to review full report at Codecov.
|
coolo
reviewed
Apr 5, 2017
assets/sass/theme_variables.scss
Outdated
| @@ -299,7 +299,7 @@ $screen-tablet: $screen-sm-min !default; | |||
|
|
|||
| // Medium screen / desktop | |||
| //** Deprecated `$screen-md` as of v3.0.1 | |||
| $screen-md: 992px !default; | |||
| $screen-md: 1190px !default; | |||
There was a problem hiding this comment.
this is not md then - this is just 10 px off lg
coolo
reviewed
Apr 5, 2017
templates/main/group_builds.html.ep
Outdated
| @@ -2,7 +2,7 @@ | |||
| % my $build = $build_res->{build}; | |||
| % my $group_id; | |||
| <div class="row build-row <%= $children ? ($default_expanded ? 'children-expanded' : 'children-collapsed') : 'no-children' %>"> | |||
| <div class="col-md-4 text-nowrap"> | |||
| <div class="col-md-5 text-nowrap"> | |||
There was a problem hiding this comment.
I don't think we want 5 - why not go with sm-4 ?
Martchus
force-pushed
the
adjust_media_queries
branch
from
0e5afc1
to
ef98177
Compare
|
Using proposal by @coolo now to wrap earlier without adjusting global media queries. Looks like this:
(1st bar after change, 2nd bar before) |
Martchus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://progress.opensuse.org/issues/12942
This shows how the width of the progress bars is adjusted (the larger progress bar shows how it was before for comparison):
Alternative would be wrapping. It would look like this (not part of the PR):
Advantage would be that it works with any text length. The problem with indentation could be solved. However, it doesn't look very nice.