Handle wrong/missing job dependencies appropriately #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolo
reviewed
May 3, 2017
| my $settings = $job->settings_hash; | ||
| for my $depname ('START_AFTER_TEST', 'PARALLEL_WITH') { | ||
| for my $dependency ( | ||
| {'START_AFTER_TEST', OpenQA::Schema::Result::JobDependencies::CHAINED}, |
There was a problem hiding this comment.
if you mean to write a hash, write a hash - i.e. as START_AFTER_TEST =>
There was a problem hiding this comment.
I mean to write a tuple, but there are no tuples in Perl. So square brackets to emulate tuple with an array and then my ($depname, $deptype) = @$dependency;?
* Make the t/api/02-iso.t no longer depend on jobs being scheduled despite wrong dependencies * Prevent warnings printed when starting tests with `prove -v` * `START_AFTER_TEST=kde:32bit not found - check for typos and dependency cycles` * `START_AFTER_TEST=textmode:64bit not found - check for typos and dependency cycles`
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
=========================================
- Coverage 87.21% 87.2% -0.02%
=========================================
Files 104 104
Lines 7354 7363 +9
=========================================
+ Hits 6414 6421 +7
- Misses 940 942 +2
Continue to review full report at Codecov.
|
* Show error messages in web UI * Abort scheduling jobs if dependencies wrong/missing See https://progress.opensuse.org/issues/10902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages and https://progress.opensuse.org/issues/10902