Inspect failed modules in /tests/overview #1335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1335 +/- ##
==========================================
+ Coverage 87.01% 87.13% +0.11%
==========================================
Files 101 101
Lines 7392 7398 +6
==========================================
+ Hits 6432 6446 +14
+ Misses 960 952 -8
Continue to review full report at Codecov.
|
|
cool! I will take a look into the code implementation later. reg. AC3: Take a look at https://openqa.opensuse.org/tests/overview?distri=opensuse&groupid=1&version=Tumbleweed&arch=x86_64&test=extra_tests_in_textmode . In there you see "crash java openvswitch +5" so either "crash", "java" or "openvswitch" should show up in case you use your new filter feature but as well should the other 5 failing modules be. In this case that is e.g. rabbitmq and details as can be seen in the jobs details https://openqa.opensuse.org/tests/407072 |
|
great! |
lib/OpenQA/Schema/ResultSet/Jobs.pm
Outdated
| { | ||
| 'modules.name' => {-in => $args{failed_modules}}, | ||
| 'modules.result' => | ||
| {-in => [OpenQA::Schema::Result::Jobs::FAILED, OpenQA::Schema::Result::Jobs::SOFTFAILED]}, |
There was a problem hiding this comment.
For soft failed jobs we don't show the modules on the tests overview page so how would it look like when trying to filter for softfailed module "foo". Will it just show orange bubbles without any modules next to it? When in doubt, just don't do anything about softfailed, only handle failed.
templates/test/overview.html.ep
Outdated
| @@ -89,6 +89,12 @@ | |||
| <input type="text" class="form-control" name="arch" placeholder="any" id="filter-arch"> | |||
| </div> | |||
| <div class="form-group"> | |||
| <strong>Failed modules</strong> | |||
| <input name="failed_modules" type="text" id="filter-failed_modules" placeholder="shutdown,install_and_reboot"> | |||
There was a problem hiding this comment.
I would not write specific examples in the placeholder but a generic description, e.g. as in L89 "any". How about "failed modules, comma separated, e.g. mod1,mod2"? or just the examples as you gave them but with a prepended 'e.g.'
templates/test/overview.html.ep
Outdated
| <strong>Failed modules</strong> | ||
| <input name="failed_modules" type="text" id="filter-failed_modules" placeholder="shutdown,install_and_reboot"> | ||
| <%= help_popover('Help for the <em>Failed Modules</em> filter' => ' | ||
| <p>Shows only the jobs that failed the specified modules</p>') %> |
There was a problem hiding this comment.
s/jobs that failed the specified modules/jobs that failed in the specified modules/
mudler
force-pushed
the
upstream_failed_modules
branch
from
945101a
to
1b26ec3
Compare
Add query parameter 'failed_modules' on /tests/overview yielding only jobs where the module has failed
mudler
force-pushed
the
upstream_failed_modules
branch
from
1b26ec3
to
753668f
Compare
|
Think i've fixed all your reviews now.. done :o) |
|
LGTM |
Add query parameter 'failed_modules' on /tests/overview yielding only jobs where the supplied modules have failures (including soft failures)
The parameter can be set in the UI, or directly from the url:
/tests/overview?distri=sle&version=12-SP2&build=1629&groupid=25&arch=aarch64&result=failed&failed_modules=install_and_reboot,shutdown(in the image there was only a failure with shutdown and not with install_and_reboot)
Not sure if soft-failures should be listed as well, so in this implementation are showed.
@okurz can you also shed some light on AC3? (not very sure what's the suggested behavior) aside from that i think i've covered the other ACs
Would be also maybe a good idea to be able to filter also with different states per-module?
Progress related issue: Poo#12448