Avoid unit test to write on source code directory #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
tests_overwrite_sourcedir
branch
from
f1bc124
to
0021a88
Compare
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
- Coverage 86.92% 86.84% -0.09%
==========================================
Files 101 101
Lines 7427 7427
==========================================
- Hits 6456 6450 -6
- Misses 971 977 +6
Continue to review full report at Codecov.
|
Utilize Mojo::File to create specific sandboxes folders to avoid polluting source code directory with data needed for unit testing generated by local tests. Related Progress issue: https://progress.opensuse.org/issues/15138
mudler
force-pushed
the
tests_overwrite_sourcedir
branch
from
0021a88
to
3754a45
Compare
|
I think that broke https://openqa.opensuse.org/tests/408989#step/openqa_webui/26 now |
|
Not sure, this commit it's just about local tests, openQA version reported in the web interface is:
(Last part is the commit hash), that links to 5c05c24 , and thus should not include that commit. Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize Mojo::File to create specific sandboxes folders to avoid polluting source code directory with data needed for unit testing generated by local tests.
Related Progress issue: Poo#15138